yarn why: Support scoped package query#1524
Closed
evocateur wants to merge 1 commit into
Closed
Conversation
A scoped package name always has a slash in it, which was being unconditionally stripped (`'@foo/bar' => '@foo'`).
Contributor
|
This isn't a valid fix since we need to support queries like |
Author
|
@kittens Thanks for the clarification, I'll investigate a better fix. |
Contributor
|
Related to #1529. |
This was referenced Oct 28, 2016
Contributor
|
Created #1593 to fix this, pending approval. |
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This avoids breaking scoped package names when cleaning the query of
yarn why.Test plan
A scoped package name always has a slash in it, which was being unconditionally stripped (
'@foo/bar' => '@foo'). This was ascertained by a bunch of gnarlyconsole.log()statements. I regret I don't have the time to write a full test suite for this subcommand.